Refactor Mesh Constructors #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lroberts36
changed the base branch from
develop
to
lroberts36/add-forest-block-orientation
…6/refactor-mesh-constructors
10 tasks
lroberts36
changed the title
|
Passes |
…6/refactor-mesh-constructors
…6/refactor-mesh-constructors
…6/refactor-mesh-constructors
lroberts36
changed the base branch from
lroberts36/add-forest-block-orientation
to
develop
lroberts36
changed the base branch from
develop
to
lroberts36/fix-static-refinement
|
|
lroberts36
changed the base branch from
lroberts36/fix-static-refinement
to
develop
12 tasks
|
It looks like the extended tests don't pass (any more?) |
|
Ah, there was a bug. I was mapping the derefinement counts based on the legacy logical location and then trying to find them based on the forest logical location (so effectively every derefinement count was set to zero). I think this wasn't showing up previously because the test was still setting a very high number for the derefinement_count until the latest PR was merged in. Should all be fixed now. |
pgrete
approved these changes
Jun 10, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR splits up the
Meshconstructors to remove code duplication between the regular and restart mesh constructors. The main rationale for doing this is to split up the constructors so that new constructors for non-hyper-rectangular meshes can easily be added.In the process of going through this PR, I noticed that some of the user function overrides were not set in the restart constructor. Someone please confirm that it is ok to set all of these on restart.
Almost all of the changes should be just a reorganization of pre-existing code. One exception is that on restart the base mesh is built from the parameter input file, and then the base mesh properties are checked against the restart file (as opposed to directly building from the restart file information). I think there is no reason why the parameter input should be able to change the mesh properties on restart, but please correct me if I am wrong.
PR Checklist